Android: stop nudging SurfaceView into a recreate cycle during Vulkan init - #243

Cold-launching the APK left users on a black screen while native_crash.log filled with repeated VeldridException: Swapchain surface lost and Sentry first-chance dumps — the renderer was never coming up at all, just looping the framework's recovery path forever.

Root cause

OsuGameActivity.OnCreate opened with a runtime orientation write, before base.OnCreate:

protected override void OnCreate(Bundle? savedInstanceState)
{
    RequestedOrientation = ScreenOrientation.Landscape;
    ...
    base.OnCreate(savedInstanceState); // SDL constructs the SurfaceView in here

Three things make this fatal:

• Redundant. The [Activity(... ScreenOrientation = ScreenOrientation.Landscape ...)] attribute already creates the activity in landscape from the first frame.
• Documented as harmful further down in the same method (the phone branch deliberately skips runtime re-assignment because "a redundant RequestedOrientation write can still nudge the SurfaceView into a recreate cycle on some OEMs while the SDL draw thread is mid-Vulkan-init").
• Worst possible timing. Issuing it before base.OnCreate queues the request for delivery during initial SurfaceView setup — exactly the window in which VeldridDevice is polling SurfaceHandle and about to call vkCreateAndroidSurfaceKHR. The poll either times out (constructor throws, renderer dead) or hands a stale handle to the Vulkan driver (SIGSEGV on the Draw thread). Either path gives the user an indefinite black screen, and the framework's per-frame retry plus our FirstChanceException hook produce the observed log flood.

The framework side (winnerspiros/osu-framework PRs #14, #16, #17 — surface-handle poll, transient surface-lost recovery in SwapBuffers/Resize, re-snapshot before vkCreateAndroidSurfaceKHR) is already shipped in ppy.osu.Framework 2026.422.1, which is what this repo references. That recovery only helps if the surface is allowed to settle; this PR removes what was preventing it.

Changes

• osu.Android/OsuGameActivity.cs — drop the redundant RequestedOrientation = Landscape assignment at the top of OnCreate. Replace with a comment so the regression cannot quietly come back, cross-referencing the existing phone-branch invariant lower in the same method.

No other behaviour change; ScreenOrientation is still used by the [Activity] attribute and by the tablet/phone branch that runs after the SurfaceView is established.

Summary by Gitar

• ANR Prevention:
  • Implemented lastRequestedOrientation caching in OsuGameAndroid to avoid redundant binder IPC calls during orientation updates.
• Diagnostics Throttle:
  • Added global and per-exception caps to CrashDiagnostics to prevent log floods and disk I/O stalls during FirstChanceException loops.
  • Optimized FirstChanceException logging by skipping external storage writes to prevent blocking the Draw thread.

_{This will update automatically on new commits.}